Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ML_VALIDATION #658

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Remove ML_VALIDATION #658

merged 9 commits into from
Jan 16, 2025

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jan 15, 2025

Description

Please include a summary of the change and which is fixed.

  • Remove ML_VALIDATION as unnecessary. INVALID_KEY = 0 cannot be used because it means the credential is rejected with ML. Use -1 in ml_probability for NOT_APPLICABLE. Fixes Remove ml_validation from report #654

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review January 15, 2025 08:36
@babenek babenek requested a review from a team as a code owner January 15, 2025 08:36
@babenek babenek marked this pull request as draft January 15, 2025 08:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (05468db) to head (f70a6c0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   92.23%   92.19%   -0.04%     
==========================================
  Files         135      135              
  Lines        4918     4909       -9     
  Branches      800      800              
==========================================
- Hits         4536     4526      -10     
  Misses        241      241              
- Partials      141      142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review January 15, 2025 09:34
@babenek babenek marked this pull request as draft January 15, 2025 09:46
@babenek babenek marked this pull request as ready for review January 15, 2025 10:41
tests/test_app.py Outdated Show resolved Hide resolved
credsweeper/credentials/candidate.py Outdated Show resolved Hide resolved
Co-authored-by: ShinHyung Choi <[email protected]>
@babenek babenek marked this pull request as draft January 15, 2025 11:00
@babenek babenek marked this pull request as ready for review January 15, 2025 11:38
@babenek babenek requested a review from csh519 January 15, 2025 11:39
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ml_validation removed well and it looks better now.

LGTM 👍

@babenek babenek merged commit 17e3bd8 into Samsung:main Jan 16, 2025
32 checks passed
@babenek babenek deleted the no-ml-validation branch January 16, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ml_validation from report
5 participants